Repository navigation
hermetic: run dx generate and dx coverage inside the isolated consumer - #6440
Merged
Merged
Conversation
#6188) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6188
Adds two network-denied probes,
dx_generate_checkanddx_coverage, run after the bazel coverage probe when the manifest has coverage patterns. dx runs with a PATH whose first entry is a run-localbazelwrapper that execs the resolved bazelisk with--output_user_root. Both probes are required inverify_evidence, with unit cases.Deviations: the wrapper script replaces a bind mount, and
dx generatehas no--checkflag (it checks by default).Tests:
hermetic_unit_testpasses. Not run://tools/testing/hermetic:cpp_rust(nested Bazel), so the new probes are unverified end to end.Assisted by Claude.
🤖 Generated with Claude Code
https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK