Skip to content

release: route asset uploads through release_driver and split the attest job - #6441

Merged
TrapsterDK merged 2 commits into
mainfrom
fix-6193-release-assets
Nov 4, 2026
Merged

TrapsterDK merged 2 commits into
mainfrom
fix-6193-release-assets

Conversation

@TrapsterDK

Copy link
Copy Markdown
Collaborator

Closes #6193

  • upload becomes attest: contents: read plus id-token and attestations, no Bazel. It hands out/ and files.list on as an artifact.
  • New assets job (contents: write only) runs release_driver <tag> <commit> <assets...>, writes the ledger JSON to $GITHUB_STEP_SUMMARY, then runs the download, sha256sum -c and dx --version checks.
  • The shell exists/cmp/extra-asset loop is gone.
  • Tests in tools/ci/release_assets_test.rs updated: driver call, no clobber, permissions per job. RELEASING.md and workflows README adjusted.

Tests: //tools/ci:release_assets_test passes except 4 tests that fail on main too (pins at 0.0.0, launcher pins, and a dx install check the workflow does not have). Workflow not run; no CI dispatched. Lint step of dx check failed during apply; not investigated.

Assisted by Claude.

🤖 Generated with Claude Code

https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK

TrapsterDK and others added 2 commits November 4, 2026 21:19
…est job (part of #6193)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011u9TXHDZrfmzFQ2WT8QAKK
The files list lives under out/, the sums are built in the source job, and the upload job is now attest.

Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
@TrapsterDK
TrapsterDK force-pushed the fix-6193-release-assets branch from 8cc20e2 to 8806174 Compare November 4, 2026 20:24
@TrapsterDK
TrapsterDK merged commit ce3f54f into main Nov 4, 2026
@TrapsterDK
TrapsterDK deleted the fix-6193-release-assets branch November 4, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

release: route asset uploads through release_driver and split the attest job

1 participant