Skip to content

BUG: 'parse_process_args: unhandled ros-arg [--log-level|INFO]' #72

Open

Description

@ikcalB

TL;DR: To me it looks like, --log-level (and the subsequent level, i.e. INFO) are not processed at all, and therefore generate warnings.

Log output from a working launch configuration:

...
[WARNING] [sim.py] [2026-06-24 16:37:18.093063]      
parse_process_args: unhandled ros-arg --log-level
[WARNING] [sim.py] [2026-06-24 16:37:18.093402]
parse_process_args: unhandled ros-arg INFO
...

In file better_launch/elements/foreign_node.py 198-250 --ros-args parameters to spawned nodes are processed.
It looks like --log-level argument is added in elements/node.py 190-194.

I think we should add handling for the --log-level argument?

Activity

  1. ikcalB commented on Jul 13, 2026

    @ikcalB
    Author

    @ndahn are you busy on other projects // does the DKFI continue support for better_launch?

    As a small team, we don't currently have much capacity to improve better_launch directly (aside from small bug fixes), so please don't take this as being rude.

  2. ndahn commented on Jul 14, 2026

    @ndahn
    Collaborator

    No worries, and sorry for the lack of updates :) I'm very busy right now, but better_launch is not abandoned. I will take a closer look at the new issues soon! Thanks for the feedback and sorry for the delay ~

  3. ikcalB commented on Jul 15, 2026

    @ikcalB
    Author

    Thanks for your reply - I'm happy to hear BL goes on :-)

    I feel no need for you to apologize!
    Please let me know, how we can be more helpful.

    (I've not yet submitted PRs, because I feel my "fixes" lack quality - I'm not experienced in either Python or this codebase)

  4. ndahn commented on Aug 13, 2026

    @ndahn
    Collaborator

    Don't worry about it! I'll have a closer look at it soon (tm), but I think that part of better_launch deserves a general overhaul, so... no ETA for now 🥲

  5. ikcalB commented on Aug 13, 2026

    @ikcalB
    Author

    Alright, thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions