Repository navigation
3151: Fix sentry backend release - #3155
Conversation
LLM Review (verdigado-think)General AssessmentThe PR focuses on refining the CI/CD pipeline and the backend build process, specifically regarding how release builds are handled, versioning is enforced, and Sentry source bundles are uploaded. Backend (Build Configuration)The changes in
CI/CD (CircleCI)
Commit Messages & Labels
Security & Quality
|
|
We should always fail in such situations, a fallback is not helpful here. |
|
So for test builds you always have to provide a version number? |
|
I meant that for production builds a missing version number should fail or at least produce an immediately recognizable wrong version number. |
i've also realized that we are not properly uploading sentry related meta infos |
|
Mh, I don't get what you mean from the linked output. On a completely other note: why are we using docker layer caching here? Completely unnecessary and crazy expensive. |
That's a log from dev delivery and all sentry related things were skipped which should not be |
|
So |
…builds and release build, filter sourceSets to deliver only main
|
@andrew8er and @seluianova Afaics we only have transactions for staging: The issue was when i remember right that we couldn't set the version number via properties file |
andrew8er
left a comment
There was a problem hiding this comment.
The Sentry plugin does need a lot of hand holding for basic tasks.
Looks good.
seluianova
left a comment
There was a problem hiding this comment.
looks good, thanks for tackling this!
Short Description
Currently we get in sentry only release with version
1.0.0instead of the real version number that we pass to gradle in the build process. The problem appears to be that the build process starts before the version bump is finished, so no release version number is available and it uses the fallback.Proposed Changes
isReleaseBuildsystem environment variable to distinguish between test builds (commit_main) and release buildssetup_remote_dockerfrombuild_backendsincedistJarruns no testsNEW_VERSION_NAMESide Effects
Testing
Resolved Issues
Fixes: #3151