fix: guard decryptors map with RWMutex to prevent data race - #9
Merged
Merged
Conversation
Member
|
I would generally recommend to use https://github.com/thomas-vilte/dave-go |
Contributor
Author
|
Yep, faced it in integration tests with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix data race on session decryptors map
Problem
The
session.decryptorsmap (golibdave/golibdave.go) was accessed concurrentlywithout synchronization:
Decrypt,MaxDecryptedFrameSize) reads from the map onper-frame decode goroutines.
AddUser,RemoveUser) mutates the map when usersjoin or leave the voice channel.
A read on the audio goroutine racing with a write on the event goroutine is a
data race on a Go map, which can panic ("concurrent map read and map write") or
corrupt the map.
Fix
Guard the
decryptorsmap with async.RWMutex