Repository navigation
Honour dynamics.duration on v2 light and grouped_light updates - #1157
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the v2 API a transition is sent as
dynamics.duration(milliseconds), for examplePUT /clip/v2/resource/light/<id>with{"on": {"on": true}, "dynamics": {"duration": 4000}}.v2StateToV1only looked at the non-standard top-leveltransitiontime, so the duration was dropped and every v2 change ran with the protocol's default transition.v2StateToV1now convertsdynamics.durationto v1transitiontime(100 ms steps). LightPUTs (Light.setV2State) andgrouped_lightPUTs (setV2Action) both go through it, so both get the transition. From there it takes the same path as a v1 request withtransitiontime.dynamics.speed(effect speed) is still handled inLight.setV2Stateas before, and the old top-leveltransitiontimestill wins if a client sends it.Tests:
tests/test_v2_state_conversion.pycovers the duration conversion, rounding, and thatspeedalone sets no transition. The duration cases fail on master;pytest testspasses.