Repository navigation
ESPHome: fix TypeError when an RGBW light gets on/bri without a colour - #1167
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an
ESPHome-RGBWlight,getLightTypepicks the white or colour LED from the request. When the request has no colour (onlyon,bri,transitiontime...), it falls back to the light's current colour mode vialight["state"]["colormode"].Lightisn't subscriptable, so that raisesTypeErrorandLight.setV1Statemarks the light unreachable. In practice, turning an RGBW ESPHome light on or dimming it without touching the colour failed.The fallback now reads
light.state["colormode"].Tests:
tests/test_esphome_rgbw.pyturns an RGBW light on in ct and xy mode and dims it in hs mode, and checks which LED endpoint is used (postRequestmocked). They fail on master with theTypeError;pytest testspasses.