Repository navigation
Accept event dispatcher - #1599
Merged
Merged
Conversation
This library uses only one method of the EventManager: dispatchEvent(). doctrine/event-manager 2.1.0 introduced an interface with just that method. Version 3.7.0 of doctrine/orm has started using EventManagerInterface as a return type for EntityManager::getEventManager(), although it continues to return EventManager. It might stop doing so in 4.0.0, so let us adapt, since we do not actually need an EventManager instance. I decided to drop support for doctrine/event-manager < 2.1 since doing so allows avoiding union types, and since v2 is easy to adopt, and well adopted already.
greg0ire
force-pushed
the
relax-em-to-ed
branch
from
October 4, 2026 13:04
f04857d to
31c202a
Compare
SenseException
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library uses only one method of the
EventManager:dispatchEvent().doctrine/event-manager2.1.0 introduced an interface with just that method.Version 3.7.0 of
doctrine/ormhas started usingEventManagerInterfaceas a return type forEntityManager::getEventManager(), although it continues to returnEventManager. It might stop doing so in 4.0.0, so let us adapt, since we do not actually need anEventManagerinstance.I decided to drop support for
doctrine/event-manager< 2.1 since doingso allows avoiding union types, and since v2 is easy to adopt (it still supports PHP 8.1), and well
adopted already.