Repository navigation
Conversation
OffsetPaginator::paginate() always fetches a window of rows, so getting the total alone meant paginating and discarding the items. The legacy Paginator::count() was the only count-only entry point, and it is deprecated. count() runs the same COUNT query as WindowPage::getTotalCount(), and nothing else, which covers pagination adapters that separate counting from slicing, clamping a requested page number, or totals displayed without a listing. Fixes doctrine#12636
seb-jean
force-pushed
the
offset-paginator-count
branch
from
October 7, 2026 10:03
308484d to
d0ef854
Compare
Contributor
Author
|
cc @hlecorche |
greg0ire
reviewed
Oct 7, 2026
| never affects a page you already hold. | ||
|
|
||
| When only the total is needed — to clamp a requested page number before | ||
| fetching it, to display a "N results" badge, or to cache the total separately |
Member
There was a problem hiding this comment.
Suggested change
| fetching it, to display a "N results" badge, or to cache the total separately | |
| fetching it, to display an "N results" badge, or to cache the total separately |
greg0ire
reviewed
Oct 7, 2026
|
|
||
| When only the total is needed — to clamp a requested page number before | ||
| fetching it, to display a "N results" badge, or to cache the total separately | ||
| from the pages — ``count()`` runs the ``COUNT`` query alone, without fetching |
Member
There was a problem hiding this comment.
Could count end up being ambiguous? Is there a possibility that we add a method that allows to count pages in the future? If yes name this one getTotalCount, and the other getPageCount() or something like that?
|
I ported my paginator to it on this branch: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12636
Counterpart of #12627: adds a way to get the count without fetching rows.
count()runs the same COUNT query asWindowPage::getTotalCount(), and nothing else.