Repository navigation
🐛 fix(logging): register channels before preparing reload routes - #323
Merged
Merged
Conversation
Resolve newly declared access-log destinations before building listener states on reload. Cover Admin and signal reloads with real-binary Pingclairfile regressions. Fixes #322 Co-authored-by: Codex <codex@openai.com>
dorianverlaine
added a commit
that referenced
this pull request
Oct 9, 2026
Resolve newly declared access-log destinations before building listener states on reload. Cover Admin and signal reloads with real-binary Pingclairfile regressions. Fixes #322 Co-authored-by: Codex <codex@openai.com>
dorianverlaine
added a commit
that referenced
this pull request
Oct 9, 2026
帶進 main 的三個提交：release 頁首行、log channel 在 reload 路由前註冊的 修復（#323），以及 listener 可允許下劃線命名字段的新配置能力（含 proxy header alias 與 integration 測試）。 # Conflicts: # pingclair-config/src/caddyfile/adapter/underscore_headers.rs # pingclair-config/src/compiler.rs # pingclair-config/src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 What this changes
Register newly declared access-log channels before building listener routes on reload, including the first listeners loaded through Admin. Sites can write to channels declared in the same configuration without a restart.
Closes #322.
🤔 Why
The previous ordering built and published site states before registering their log destinations. Reload succeeded and created the file, but the sites retained no logger for it.
🔬 Evidence
just ci: 2,071 tests passed, 10 skipped; lint and benchmark smoke passed. The run used a temporaryPINGCLAIR_TLS_STOREbecause the sandbox prevents an existing port-conflict test from accessing the default store. The initial run preserved this environment failure: 2,070 passed, one failed before its port assertion.git diff --checkpassed.🔀 Both transports?
H1/H2 and H3 consume the same prepared site states. Real-binary regressions exercise HTTP/1.1; H3 was not separately exercised for this ordering change.
📚 Documentation
README and CHANGELOG describe newly declared log channels becoming usable on reload.
🤖 Which AI helped?
Codex implemented the change and ran validation.