docs(clustering): correct the stale server-heartbeat interval comment

[dsolistorres]

Proposed Changes

Fixes #37015.

SERVER_HEARTBEAT_RUN_EVERY_SECONDS defaults to 60, but the trailing comment read // runs every 5 seconds.

-       final int delaySeconds = Config.getIntProperty("SERVER_HEARTBEAT_RUN_EVERY_SECONDS", 60); // runs every 5 seconds.
+       // Both default to one minute, matching the HEARTBEAT_CRON_EXPRESSION (0 0/1 * * * ?) this
+       // replaced when the schedulers were unified. The cadence bounds how quickly a node notices
+       // a cluster membership change or retries a failed cache-transport rewire.
+       final int delaySeconds = Config.getIntProperty("SERVER_HEARTBEAT_RUN_EVERY_SECONDS", 60);

Why it was wrong

Not a default that changed and left the comment behind — the comment was wrong when it was written.

999036092e (#19291, unifying the 3 quartz schedulers, Oct 2020) created this block by adapting the SystemEventsJob block ~150 lines above:

final int delaySeconds = Config.getIntProperty("SYSTEM_EVENTS_DELAY_SECONDS", 5); // runs every 5 seconds.

That one is correct — it really does default to 5. The heartbeat copy changed the property name and the default to 60 and kept the comment verbatim.

The cadence never changed either. Before that commit the heartbeat was a Quartz CronTrigger on HEARTBEAT_CRON_EXPRESSION, defaulted to 0 0/1 * * * ? in dotcms-config-cluster.properties — once a minute. The 60-second fixed delay preserved it; only the mechanism changed.

Testing

Comment only, no behaviour change — nothing to test. Found while tracing the heartbeat cadence for #36803, where this interval bounds how quickly a failed cache-transport rewire is retried.

🤖 Generated with Claude Code

[claude]

Claude finished @dsolistorres's task in 28s —— View job

---

Code Review

• Read the diff (DotInitScheduler.java) and surrounding context
• Verify the comment's accuracy against the code

New Issues

No issues found.

The change is comment-only. It's accurate on every point I can verify from the code:

• SERVER_HEARTBEAT_RUN_EVERY_SECONDS defaults to 60 (DotInitScheduler.java:587), so the old inline // runs every 5 seconds. was wrong — the new "one minute" wording is correct.
• SERVER_HEARTBEAT_INITIAL_DELAY_SECONDS also defaults to 60 (DotInitScheduler.java:583), so "Both default to one minute" holds.
• The cron expression 0 0/1 * * * ? cited in the comment does fire once per minute, matching the 60-second scheduleAtFixedRate delay — the equivalence is stated correctly.

No behavior change, no test impact. Clean.

• fix-stale-heartbeat-interval-comment