Updates - #5279
Draft
timcassell wants to merge 1 commit into
Draft
Conversation
Update recommended config. Reenable concurrent benchmarks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5092
Resolves #5192
Updated recommended config.
Re-enabled concurrent benchmarks.
Added
MonoAotLLVMToolchainafter BDN removed it in dotnet/BenchmarkDotNet#3232.I looked at removing
monoaotllvm, but it was more far-reaching than I was comfortable with, so I opted to port the toolchain here instead. If you guys no longer want it, someone with more knowledge of the cross-cutting concerns can remove it.Leaving this as draft until dotnet/BenchmarkDotNet#3232 is merged, but please feel free to leave feedback (on either PR).