Fix fatal_array test for 32-bit systems#301
Open
pghmcfc wants to merge 1 commit into
Open
Conversation
On 64-bit systems, SIZE_MAX is much bigger than UINT_MAX so an allocation of UINT_MAX objects is not unreasonable. On 32-bit systems, SIZE_MAX and UINT_MAX are the same so an allocation of UINT_MAX objects fails malloc checks before reaching buffer size limit checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On 64-bit systems,
SIZE_MAXis much bigger thanUINT_MAXso an allocation ofUINT_MAXobjects is not unreasonable.On 32-bit systems,
SIZE_MAXandUINT_MAXare the same so an allocation ofUINT_MAXobjects failsmallocchecks before reaching buffer size limit checks.