Implement RETURN_GENERATED_KEYS support via DML RETURNING rewrite - #829
Merged
staticlibs merged 3 commits intoAug 24, 2026
Merged
Conversation
staticlibs
approved these changes
Aug 23, 2026
staticlibs
left a comment
staticlibs
left a comment
Member
There was a problem hiding this comment.
Hi, thanks for the PR! It looks good to me, I added just one question and a couple of nits.
The parsing code may be not elegant, but I can see no other easy ways to implement it. We don't want to introduce real Java-level SQL parsers, as in future we are going to add a native parser extension to handle date time literals like {d 'yyyy-mm-dd'}. At that point going to look into changing current ad-hoc rewriting code to use a parser extension too.
Contributor
Author
|
tried to address the feedbacks |
Member
|
Thanks for the update! |
staticlibs
added a commit
that referenced
this pull request
Aug 24, 2026
This is a backport of the PR #829 to `v1.5.5` stable branch. Co-Authored-By: Romain Manni-Bucau <rmannibucau@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background: using JDBC API with RETURN_GENERATED_KEYS in the original application totally broke with duckdb, this provides a fallback which should work most of the time
side note: no issue to close my PR if you want to implement it totally differently, I'm not ultra proud of the string parsing