Repository navigation
Fix statesync - #60
Merged
Merged
Conversation
The light client implementation compares the `ValidatorSet` instances received from different sources (the primary against one or more witnesses). In particular, the state of the proposer selection algorithm, represented by the `ProposerPriority` field of each `Validator` present in the `ValidatorSet`, should be identical. In order to compare those fields, we add a`ProposerPriorityHash()` to the `ValidatorSet` type. This is needed because the `Hash()` method of the same type does not include the `ProposerPriority` fields in its computation. When the light client detects distinct states of the proposer selection algorithm, the `VerifyLightBlockAtHeight` method of the `light.Client` type, used for instance by the state sync protocol, returns an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The light client implementation compares the
ValidatorSetinstances received from different sources (the primary against one or more witnesses). In particular, the state of the proposer selection algorithm, represented by theProposerPriorityfield of eachValidatorpresent in theValidatorSet, should be identical.In order to compare those fields, we add a
ProposerPriorityHash()to theValidatorSettype. This is needed because theHash()method of the same type does not include theProposerPriorityfields in its computation.When the light client detects distinct states of the proposer selection algorithm, the
VerifyLightBlockAtHeightmethod of thelight.Clienttype, used for instance by the state sync protocol, returns an error.PR checklist
.changelog(we use unclog to manage our changelog)docs/orspec/) and code comments