Repository navigation
deps: bump the cometbft fork to 00f56e561ffd - #3461
Conversation
- blocksync: validate block response sender and signature count - blocksync: verify extended commits before storing them and stay in block sync without a servable peer - types: reject light client attack evidence without a signed header
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update CometBFT revision protocol/go.mod |
The CometBFT replacement now uses revision v0.38.6-0.20261029164742-00f56e561ffd instead of v0.38.6-0.20261014020802-ab0baf2bacac. |
Priority:
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Other
Suggested reviewers: kefancao
Merge Risk: 
Minimal · up to d59b4
-
No merge-blocking issue is established for this dependency update. It is mergeable subject to normal build and test checks.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Full details: Description check
-
Explanation
The description clearly explains the dependency bump and the included upstream changes, but it does not follow the required template. It omits the Changelist and Test Plan headings and the Author/Reviewer Checklist.
Resolution
Rewrite the description using the required template. Add a Changelist section, a Test Plan section with the executed build and test commands, and the complete Author/Reviewer Checklist with applicable labels addressed or marked.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
|
@Mergifyio backport release/protocol/v9.x |
✅ Backports have been createdDetails
Cherry-pick of 7b8822a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Moves the cometbft fork pin from
ab0baf2bacac(2026-10-14) to the currentdydx-fork-v0.38.5head00f56e561ffd, picking up:types: reject light client attack evidence whose conflicting block has no signed header.blocksync: validate the sender and signature count of block responses (upstream fix(blocksync): validate blocksync response sender and signature count (backport #5860) cometbft/cometbft#5863).blocksync: verify a peer's extended commit against the validator set before persisting it, and stay in block sync while no peer can serve the next height.All three are node-local (block sync, evidence validation, p2p message handling) with no state-machine or proposal changes, so the bump is safe for a rolling patch. Only
go.mod/go.sumchange here.Summary by CodeRabbit