fix: render boxPlot outliers after updateDataSync from empty data - #3
Closed
dyk1454683243-sudo wants to merge 1 commit into
Closed
dyk1454683243-sudo wants to merge 1 commit into
dyk1454683243-sudo wants to merge 1 commit into
Conversation
…ataSync Register array-min/array-max for outliersField even when empty initial data omits that key, so updateDataSync can render outlier points. Co-authored-by: David <dyk1454683243-sudo@users.noreply.github.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes VisActor#4270
🤔 This is a ...
🔗 Related issue link
Fixes VisActor#4270
🔗 Related PR link
Separate from VisActor#4693 / VisActor#4694. Branched from current upstream
develop.💡 Background and solution
Constructing a
boxPlotwith empty data plusoutliersField, then filling viaupdateDataSync, did not render outlier points from the array field (they do render when the same data is present at init).getStatisticFields()only rewrote operations whenoutliersFieldwas already present insuper.getStatisticFields(). Empty initial data can omit that key, so the field never received['array-min', 'array-max']and laterupdateDataSynccould not expand the value domain / fold outliers correctly.This change always registers
outliersFieldwitharray-min/array-maxwhen the spec sets it (update if present, push if missing).foldOutlierDataandviewDataUpdate→_outlierData.updateData()are unchanged.📝 Changelog
outliersFieldstatistics soupdateDataSyncfrom empty data still renders outlier pointsoutliersField注册 array-min/array-max 统计，使updateDataSync后异常点能正常渲染☑️ Self-Check before Merge
Tests
getStatisticFields()adds or rewrites theoutliersFieldentry with['array-min', 'array-max']when the key is missing or present, and does nothing whenoutliersFieldis unset.values+outliersField: 'y6'→updateData('boxPlot', y6 array rows)produces folded outlier rows[12.01, 12.02, 14.03]andy6min/max statistics.outliersFieldstill folds those rows.foldOutlierDatastill expands each numeric value in an outliers array.Verification
Lint/test on touched packages will be recorded after this pre-testing revision.