Repository navigation
test(e2e): macos tap resamples, tighten checks to per-channel gain and snr - #72
Merged
Merged
Conversation
… the tap resampler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigates whether the macOS e2e recording can be bit-equal to the offline render, as on Windows. It cannot, and the cause is in the product path, not only in the test capture. This PR documents the cause with measurements and tightens the macOS checks as far as the evidence allows.
Finding (spec section 14.4)
The Process Tap's leg of an aggregate device contains a sample-rate converter that no public option disables.
kAudioSubTapDriftCompensationKeyoff (read back from the composition), drift quality 0 or 127, tap kind (device-bound, global stereo, global mono), mute behaviour, or stacked.HalInputStreamis in bypass in every run.Changes
transfer_min_snr_db.contrib/e2e/macos/tapcap.mis the experiment tool used for the table in 14.4.Verification
make checkis green.cargo xtask e2e --os macos --tier fullon the macOS guest: every transfer check passes on all channels. The only failures are the existing latency-baseline gates (88.2, 96, 192 kHz and 44.1 kHz x16), which already failed the same way before this change. The baselines hold implausible negative values and were not touched.