Repository navigation
fix(e2e): windows long-run slip was the recorder reallocating in the capture callback - #74
Merged
Merged
Conversation
…never stalls; report slips explicitly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The long-full-eq@96000x8 scenario lost 768 frames once at a fixed frame after the soaks, then matched bit-exactly again, shifted.
Root cause: the recording Vec grew by doubling inside the WASAPI loopback capture callback. It outgrows its 120 MiB block at frame 3,932,160 (3840 * 2^10) and reallocates to 240 MiB; the callback stalled up to 28 ms (normally 1-3 ms), the engine's loopback buffer overran and dropped audio. Product (APO, daemon) was not involved.
Changes:
Evidence: old code on --scenario 'eq' reproduced the failure (slowest callback 28.7 ms, slip at frame 3931584); with the fix the same subset passes (slowest callback 12.5 us, 0 growths); full Windows tier 25/25 pass. One earlier full run with the fix had a single soak-flat dropout (callback 84 us, not the recorder) that did not recur.