Repository navigation
fix(linux): ignore stale volume read-backs after our own write - #77
Merged
Merged
Conversation
PipeWire echoes every intermediate value of a drag back late. Applying them reverted the optimistic sink/app volume, and sync_master_volume then mirrored the stale value onto the resonance sink, so the system volume bar jumped back and forth. Skip volume/mute read-backs for 300 ms after we write a node; the next poll lands the real value. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dragging a volume slider made the system volume bar (DMS) jitter ~0.1 s.
Root cause (by code trace)
PipeWire reports intermediate route/props values back late. The daemon applied them to the optimistic sink/app volume, then
sync_master_volumemirrored the stale device value onto the "resonance" default sink, so the system bar jumped back, then forward again when the fresh read-back landed.Fix
Skip volume/mute read-backs for 300 ms after we write a sink/app node (
echo_pending); the next 200 ms route poll lands the real value. Unit test for the window.Not reproduced
The Applications-panel flicker did not reproduce: with a private PipeWire and 3 playing streams the daemon published only on stream add and the GUI rendered pixel-identical frames. This PR may not fix it.
🤖 Generated with Claude Code