attempt at fixing some visual issues with the model editor #407 - #345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model switching and selection state refresh:
setCurrentModelIndex, the assembly and layer indices are now reset to zero, and the assembly selection state is refreshed to ensure the UI shows the correct layers and assemblies for the new model.UI synchronization improvements:
MultiLayer.qmlandSurfactantLayer.qml, combo boxes for material and solvent selection now track their respective layer properties directly. This ensures that the correct selection is shown even if the assemblies or layers are refreshed without changing the list of materials or assembly names.ModelEditor.qml, the assembly type combo box now tracks the assembly's own type property, ensuring it stays in sync with the data model after a refresh.ModelSelector.qml, model name edits are now committed live as the user types, so other UI elements (like the model editor title) update immediately.