Skip to content

Replace CollectionBase in MultiFitter with EasyList #304

Description

@rozyczko

easyscience.fitting.multi_fitter.MultiFitter.__init__ wraps its fit objects in the deprecated CollectionBase, so every multi-object fit throws deprecation warnings even though the calling code (e.g. easyreflectometry) has already migrated off CollectionBase entirely.

MultiFitter should use EasyList (or another non-deprecated container) instead, so downstream consumers stop seeing this warning on ordinary fits.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

[area] base classesChanges to or creation of new base classes[priority] highShould be prioritized soon[scope] maintenanceCode/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions