Repository navigation
Fix the reference error in Parameter - #51
Merged
Merged
Conversation
seventil
added
[scope] bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #51 +/- ##
=========================================
Coverage ? 0.00%
=========================================
Files ? 4
Lines ? 387
Branches ? 0
=========================================
Hits ? 0
Misses ? 387
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Also noticed an issue with padding in units. Here how regular text and degrees look currently and here how they look with proposed topPadding added: |
…rtically both with the title and without
Contributor
Author
|
The new implementation centers the units to the TextField text: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instantiating
EaElements.Parametercomponent as is results in a reference error:EasyApp/src/EasyApplication/Gui/Elements/Parameter.qml:22:5: ReferenceError: parameterFieldWidth is not definedThis PR removes
widthdefinition fromEaElements.Parameter, which results in a fallback onTextField'sImplicitWidth.