Skip to content

378 remove datastore - #409

Merged
rozyczko merged 4 commits into
developfrom
378-remove-datastore
Sep 14, 2026
Merged

rozyczko merged 4 commits into
developfrom
378-remove-datastore

Conversation

@rozyczko

Copy link
Copy Markdown
Member

This pull request removes the unused DataStore and ProjectData classes from the easyreflectometry.data module and improves the serialization behavior of the Project class. It also ensures that experiment metadata is correctly recorded and loaded, even when x-uncertainties are missing.

Removal of unused data container classes:

  • Deleted the DataStore and ProjectData classes from src/easyreflectometry/data/data_store.py, as they were unused, broken, and not referenced in the library, GUI, or documentation.

Serialization and experiment handling improvements:

  • Modified Project.as_dict to always record an experiment's name and model, even if the experiment's xe (x-uncertainty) is None, preventing issues when loading projects with such experiments.
  • Updated _from_dict_extract_experiments in project.py to correctly handle experiments that lack xe.

@rozyczko rozyczko added chore Chore changes to the code [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH) [priority] high Should be prioritized soon labels Sep 11, 2026
@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.52%. Comparing base (10f01c7) to head (83766a0).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #409      +/-   ##
===========================================
+ Coverage    94.42%   94.52%   +0.09%     
===========================================
  Files           54       54              
  Lines         5562     5516      -46     
===========================================
- Hits          5252     5214      -38     
+ Misses         310      302       -8     
Flag Coverage Δ
integration 38.32% <0.00%> (-0.07%) ⬇️
unittests 94.52% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyreflectometry/data/__init__.py 100.00% <ø> (ø)
src/easyreflectometry/data/data_store.py 100.00% <ø> (+8.16%) ⬆️
src/easyreflectometry/project.py 94.26% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rozyczko
rozyczko merged commit dd3cb93 into develop Sep 14, 2026
55 checks passed
@rozyczko
rozyczko deleted the 378-remove-datastore branch September 14, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Chore changes to the code [priority] high Should be prioritized soon [scope] maintenance Code/tooling cleanup, no feature or bugfix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant