Enforce MinHash construction compatibility - #326
Open
dipeshbabu wants to merge 4 commits into
Open
dipeshbabu wants to merge 4 commits into
dipeshbabu wants to merge 4 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
=========================================
Coverage ? 71.96%
=========================================
Files ? 21
Lines ? 2857
Branches ? 0
=========================================
Hits ? 2056
Misses ? 801
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
dipeshbabu
force-pushed
the
agent/enforce-minhash-compatibility
branch
3 times, most recently
from
July 22, 2026 05:48
5174eb4 to
ace3414
Compare
dipeshbabu
force-pushed
the
agent/enforce-minhash-compatibility
branch
from
August 20, 2026 17:51
ace3414 to
cdd3632
Compare
Contributor
Author
|
The red job failed in the unchanged HNSW removal test. I reran it with the MinHash and LSH tests: all 169 passed. I don't have permission to rerun upstream CI; could you rerun the failed jobs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MinHash sketches can share a seed, length, and scheme while using different permutation matrices or hash functions. Track construction metadata and reject incompatible comparisons, merges, and LSH operations instead of returning invalid similarity results.
The callable fingerprint includes partial arguments, bound-instance state, defaults, closures, and callable state. Source filenames and line locations do not affect compatibility, so persisted indexes can be used after relocating an installation. WeightedMinHash remains exempt, and legacy scheme-only metadata remains readable.
Validation