Skip to content

chore: upgrade angie-sdk to Node.js 24 - #111

Merged
matipojo merged 1 commit into
masterfrom
cursor/node-24-upgrade-ca4e
Sep 23, 2026
Merged

matipojo merged 1 commit into
masterfrom
cursor/node-24-upgrade-ca4e

Conversation

@matipojo

@matipojo matipojo commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Problem

CI still tested Node 16/18/20 and publish/deploy jobs ran on Node 18/20. The new npmjs publishing method needs npm 11.5.1+, which ships with Node 24.

Solution

  • Add .nvmrc with 24
  • Pin all GitHub Actions Node jobs to 24 (ci, publish, publish-beta, deploy-demo, videoproof-ci)
  • CI matrix: single job on Node 24 (drop EOL 16/18/20)
  • package.json: engines.node >=24.0.0, @types/node ^24
  • Refresh package-lock.json for @types/node
  • Demo plugin README prerequisite: Node 24+

No unrelated dependency or application code changes.

How to verify

nvm use    # reads .nvmrc → 24
npm ci
npm run lint
npm test
npm run build

Verified locally on Node v24.21.0 (26 suites, 279 tests, build OK). CI green on this PR.

@cursor
cursor Bot force-pushed the cursor/node-24-upgrade-ca4e branch from 18a627c to 008f890 Compare September 23, 2026 12:33
Follow-up to elementor/elementor-ai#3529 (AI-8424): run CI, publish,
deploy, and videoproof on Node 24.

Add .nvmrc, engines.node, and @types/node ^24.

Co-authored-by: Mati Horowitz <matipojo@users.noreply.github.com>
@cursor cursor Bot changed the title [AI-9613] Improve: Upgrade angie-sdk CI/publish to Node.js 24 for npm trusted publishing [AI-8424] Improve: Upgrade angie-sdk to Node.js 24 LTS Sep 23, 2026
@cursor
cursor Bot force-pushed the cursor/node-24-upgrade-ca4e branch from 008f890 to da4cfbe Compare September 23, 2026 12:33
Comment thread .github/workflows/deploy-demo.yml
@cloud-devpos

Copy link
Copy Markdown
Contributor

Review Summary

Focused PR aligning CI, .nvmrc, package engines, and @types/node on Node 24 with no application code changes. Workflows still hardcode the version instead of reading .nvmrc, which is a minor maintainability gap.

Issues (1)

🔄 Code Patterns: Duplicate Node version literals


🤖 Code Style Review Agent

@cloud-devpos cloud-devpos added the auto-reviewed PR has been automatically reviewed by CI (auto) label Sep 23, 2026
@cloud-devpos

Copy link
Copy Markdown
Contributor

Review Summary

✅ Focused infrastructure PR that aligns Node.js 24 across engines, CI, publish workflows, .nvmrc, and documentation. No application or library source changes; configuration updates are consistent and appropriate for the version bump.


🤖 Code Style Review Agent

@cloud-devpos

Copy link
Copy Markdown
Contributor

Review Summary

✅ Focused infrastructure PR that standardizes the project and CI on Node 24 via .nvmrc, package.json engines, workflow updates, and @types/node alignment. No application source changes; no code-quality issues in scope.


🤖 Code Style Review Agent

@cloud-devpos cloud-devpos added the architect-reviewed PR has been automatically reviewed by CI (architect) label Sep 23, 2026
github-actions Bot added a commit that referenced this pull request Sep 23, 2026
github-actions Bot added a commit that referenced this pull request Sep 23, 2026
@github-actions

Copy link
Copy Markdown

🎬 Video Proof Test Results

Branch: cursor/node-24-upgrade-ca4e
Test Status: ✅ Passed

Clicked Ask Angie to open the loadSidebarV2 sidebar on the product editor POC.

📸 Screenshots

01
01

02
02

03
03

Artifacts are also available on the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 23, 2026
@github-actions

Copy link
Copy Markdown

🎬 Video Proof Test Results

Branch: cursor/node-24-upgrade-ca4e
Test Status: ✅ Passed

Clicked Ask Angie to open the loadSidebarV2 sidebar on the product editor POC.

📸 Screenshots

01
01

02
02

03
03

Artifacts are also available on the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 23, 2026
github-actions Bot added a commit that referenced this pull request Sep 23, 2026
github-actions Bot added a commit that referenced this pull request Sep 23, 2026
@github-actions

Copy link
Copy Markdown

🎬 Video Proof Test Results

Branch: cursor/node-24-upgrade-ca4e
Test Status: ✅ Passed

Clicked Ask Angie to open the loadSidebarV2 sidebar on the product editor POC.

📸 Screenshots

01
01

02
02

03
03

Artifacts are also available on the workflow run.

github-actions Bot added a commit that referenced this pull request Sep 23, 2026
@cloud-devpos

Copy link
Copy Markdown
Contributor

PR Approver Evaluation

Pre-checks did not pass — auto-merge evaluation stopped.

Reasons to auto-merge

  • None identified

Reasons not to auto-merge

  • PR is still a draft

Verdict

Would auto-merge: No — pre-checks blocked evaluation.

Fix the issues above, then push new commits to re-run.


🤖 PR Approver Agent

2 similar comments
@cloud-devpos

Copy link
Copy Markdown
Contributor

PR Approver Evaluation

Pre-checks did not pass — auto-merge evaluation stopped.

Reasons to auto-merge

  • None identified

Reasons not to auto-merge

  • PR is still a draft

Verdict

Would auto-merge: No — pre-checks blocked evaluation.

Fix the issues above, then push new commits to re-run.


🤖 PR Approver Agent

@cloud-devpos

Copy link
Copy Markdown
Contributor

PR Approver Evaluation

Pre-checks did not pass — auto-merge evaluation stopped.

Reasons to auto-merge

  • None identified

Reasons not to auto-merge

  • PR is still a draft

Verdict

Would auto-merge: No — pre-checks blocked evaluation.

Fix the issues above, then push new commits to re-run.


🤖 PR Approver Agent

@matipojo matipojo changed the title [AI-8424] Improve: Upgrade angie-sdk to Node.js 24 LTS [AI-9613] Improve: Upgrade angie-sdk to Node.js 24 Sep 23, 2026
@matipojo matipojo changed the title [AI-9613] Improve: Upgrade angie-sdk to Node.js 24 chore: upgrade angie-sdk to Node.js 24 Sep 23, 2026
@matipojo
matipojo marked this pull request as ready for review September 23, 2026 14:11
@matipojo
matipojo requested a review from a team as a code owner September 23, 2026 14:11
@cloud-devpos

Copy link
Copy Markdown
Contributor

PR Approver Evaluation

PR upgrades Node.js from 16/18/20 to Node 24 across all CI workflows, package.json engines field, and related tooling — CI workflow changes require human review per escalation policy.

Reasons to auto-merge

  • All CI checks pass, including CodeQL, Wiz security scanners (Secret, Vulnerability, SAST, IaC, Data), and the test suite on Node 24
  • Diff is coherent and single-purpose: consistent Node 24 upgrade across workflows, .nvmrc, package.json, and lockfile
  • No application logic changed — only CI configuration, dependency type stubs (@types/node), and documentation
  • The lockfile changes are limited to @types/node and undici-types version bumps consistent with the Node 24 upgrade
  • .nvmrc added to pin local development environment to match CI
  • README updated to reflect the new minimum Node version requirement

Reasons not to auto-merge

  • CI workflow files (.github/workflows/*.yml) are changed — per escalation policy, Helm charts, CI workflows, and deployment configuration changes require escalation to a human reviewer
  • Dropping support for Node 16, 18, and 20 is a potentially breaking change for consumers of the SDK who pin to older Node versions; the engines field now enforces Node >=24.0.0
  • The CI matrix was reduced from [16, 18, 20] to [24] only — no longer validates compatibility with previously supported Node versions
  • deploy-demo.yml and videoproof-ci.yml are deployment-adjacent workflow files also changed

Verdict

Would auto-merge: No — human review is required.

Please request review from rnd-ai-advanced@elementor.com.


🤖 PR Approver Agent

@matipojo
matipojo merged commit 8db0be7 into master Sep 23, 2026
18 checks passed
@matipojo
matipojo deleted the cursor/node-24-upgrade-ca4e branch September 23, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 min review architect-reviewed PR has been automatically reviewed by CI (architect) auto-reviewed PR has been automatically reviewed by CI (auto)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants