chore: upgrade angie-sdk to Node.js 24 - #111
Conversation
18a627c to
008f890
Compare
Follow-up to elementor/elementor-ai#3529 (AI-8424): run CI, publish, deploy, and videoproof on Node 24. Add .nvmrc, engines.node, and @types/node ^24. Co-authored-by: Mati Horowitz <matipojo@users.noreply.github.com>
008f890 to
da4cfbe
Compare
Review SummaryFocused PR aligning CI, .nvmrc, package engines, and @types/node on Node 24 with no application code changes. Workflows still hardcode the version instead of reading .nvmrc, which is a minor maintainability gap. Issues (1)🔄 Code Patterns: Duplicate Node version literals 🤖 Code Style Review Agent |
Review Summary✅ Focused infrastructure PR that aligns Node.js 24 across engines, CI, publish workflows, .nvmrc, and documentation. No application or library source changes; configuration updates are consistent and appropriate for the version bump. 🤖 Code Style Review Agent |
Review Summary✅ Focused infrastructure PR that standardizes the project and CI on Node 24 via 🤖 Code Style Review Agent |
🎬 Video Proof Test ResultsBranch: Clicked Ask Angie to open the loadSidebarV2 sidebar on the product editor POC. 📸 ScreenshotsArtifacts are also available on the workflow run. |
🎬 Video Proof Test ResultsBranch: Clicked Ask Angie to open the loadSidebarV2 sidebar on the product editor POC. 📸 ScreenshotsArtifacts are also available on the workflow run. |
🎬 Video Proof Test ResultsBranch: Clicked Ask Angie to open the loadSidebarV2 sidebar on the product editor POC. 📸 ScreenshotsArtifacts are also available on the workflow run. |
PR Approver EvaluationPre-checks did not pass — auto-merge evaluation stopped. Reasons to auto-merge
Reasons not to auto-merge
VerdictWould auto-merge: No — pre-checks blocked evaluation. Fix the issues above, then push new commits to re-run. 🤖 PR Approver Agent |
2 similar comments
PR Approver EvaluationPre-checks did not pass — auto-merge evaluation stopped. Reasons to auto-merge
Reasons not to auto-merge
VerdictWould auto-merge: No — pre-checks blocked evaluation. Fix the issues above, then push new commits to re-run. 🤖 PR Approver Agent |
PR Approver EvaluationPre-checks did not pass — auto-merge evaluation stopped. Reasons to auto-merge
Reasons not to auto-merge
VerdictWould auto-merge: No — pre-checks blocked evaluation. Fix the issues above, then push new commits to re-run. 🤖 PR Approver Agent |
PR Approver EvaluationPR upgrades Node.js from 16/18/20 to Node 24 across all CI workflows, package.json engines field, and related tooling — CI workflow changes require human review per escalation policy. Reasons to auto-merge
Reasons not to auto-merge
VerdictWould auto-merge: No — human review is required. Please request review from rnd-ai-advanced@elementor.com. 🤖 PR Approver Agent |









Problem
CI still tested Node 16/18/20 and publish/deploy jobs ran on Node 18/20. The new npmjs publishing method needs npm 11.5.1+, which ships with Node 24.
Solution
.nvmrcwith24ci,publish,publish-beta,deploy-demo,videoproof-ci)package.json:engines.node>=24.0.0,@types/node^24package-lock.jsonfor@types/nodeNo unrelated dependency or application code changes.
How to verify
Verified locally on Node v24.21.0 (26 suites, 279 tests, build OK). CI green on this PR.