You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@elwayman02 yea sorry I'm kinda in-progress on a lot of things with this 😂 This is the next step to try and get ember-learn/ember-styleguide#422 to work with embroider optimised and we will likely need to adjust some things making use of ember-cli/ember-try#850 too 👍
Also this is only cleaning up CI to try to keep PRs as only one logical change, the "solution" to Embroider Optomised is #58 👍
Oh and the netlify build is failing because fastboot doesn't work with embroider correctly for one of the macros we're using: embroider-build/embroider#1203
@elwayman02 yea sorry I'm kinda in-progress on a lot of things with this 😂 This is the next step to try and get ember-learn/ember-styleguide#422 to work with embroider optimised and we will likely need to adjust some things making use of ember-cli/ember-try#850 too 👍
Also this is only cleaning up CI to try to keep PRs as only one logical change, the "solution" to Embroider Optomised is #58 👍
Ack. I only mention it cuz you marked it ready for review. :P
@mansona any chance we can get this updated and landed? Addons using field-guide for their docs can't get clean embroider builds even if their actual addon code is embroider-compat, due to field-guide itself failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.