You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Node.js side PR is an update to V8. I tried bisecting what commit that could have been, but building V8 is too complex that I was not able to get it going.
Potential suspect commits are
v8/v8@090d6531c1d - Ship undefined doubles v8/v8@929a3120ecf - [wasm] Preserve old undefined pattern for wasm wrappers v8/v8@7736b861998 - [wasm-interpreter] Coerce JS call results against the callee signature
Posting this regression here since I don't currently know if this is some kind of intended behavioral change, or a bug. @sbc100@dschuff@tlively any chance you might be able to bisect what changed in V8, and if this change is to be expected?
I don't know the cadence of Node.js updating V8.. though if this is a bug, I presume it could already have been fixed in upstream V8, so it would be great to avoid Node.js from shipping with that version of V8 then.
Activity
[test] Avoid relying on NaN sign bit in `test_em_asm.cpp`. NFC
[test] Avoid relying on NaN sign bit in `test_em_asm.cpp`. NFC
[test] Avoid relying on NaN sign bit in `test_em_asm.cpp`. NFC (emscr…