Skip to content

qa-tests: add Claude's skills to improve the analysis of QA test results. - #22769

Merged
mriccobene merged 7 commits into
mainfrom
qa-tests/add-claude-skill-for-qa-test-result-analysis
Jul 30, 2026
Merged

qa-tests: add Claude's skills to improve the analysis of QA test results.#22769
mriccobene merged 7 commits into
mainfrom
qa-tests/add-claude-skill-for-qa-test-result-analysis

Conversation

@mriccobene

Copy link
Copy Markdown
Member

No description provided.

@mriccobene
mriccobene marked this pull request as ready for review July 28, 2026 10:44
@mriccobene
mriccobene requested review from Copilot and lystopad July 28, 2026 10:44
@mriccobene mriccobene changed the title qa-tests: add Claude skill to better analyse QA test results qa-tests: add Claude's skills to improve the analysis of QA test results. Jul 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new .claude skill (qa-test-results) that documents how to interpret Erigon’s long-running QA GitHub Actions workflows (sync/tip-tracking, snapshot download, clean exit, and RPC integration/performance), with concrete triage steps and per-workflow reference material.

Changes:

  • Introduces a qa-test-results Claude skill with a “cheapest signal first” triage flow and key failure-mode explanations.
  • Adds reference docs covering workflow families/artifacts, a triage decision tree, and detailed log-reading guides for sync and RPC QA suites.
  • Documents the structure/meaning of result-<chain>.json and how to use it to interpret outcomes and measures.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
.claude/skills/qa-test-results/SKILL.md Main skill guide for reading QA logs/results and interpreting common failure causes.
.claude/skills/qa-test-results/references/workflows.md Maps qa-* workflows to runner labels, drivers, artifacts, and where verdicts live.
.claude/skills/qa-test-results/references/triage.md Step-by-step decision tree for diagnosing red QA checks from cheapest signals upward.
.claude/skills/qa-test-results/references/sync-tests.md Field-by-field explanation of sync/tip-tracking report blocks and metrics.
.claude/skills/qa-test-results/references/rpc-tests.md Explains RPC integration vs performance log formats and where pass/fail is determined.
.claude/skills/qa-test-results/references/result-json.md Defines the schema/meaning of result-<chain>.json, outcomes, reasons, and measures.
Comments suppressed due to low confidence (1)

.claude/skills/qa-test-results/SKILL.md:229

  • This references a root CLAUDE.md, but there is no CLAUDE.md at the repository root; the test-skip policy lives in AGENTS.md (see the "Test skips" section). As written, the link/filename will send readers to a non-existent file.
  `batch processing with #blocks=N` and `head updated with age=N` are the
  breadcrumbs that explain a sync-time failure.
- **Never propose muting or skipping a QA test** to get a check green; see the
  project's test-skip policy in `CLAUDE.md`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .claude/skills/qa-test-results/SKILL.md Outdated
Comment thread .claude/skills/qa-test-results/references/triage.md
@AskAlexSharov
AskAlexSharov added this pull request to the merge queue Jul 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 29, 2026
@AskAlexSharov
AskAlexSharov enabled auto-merge July 29, 2026 10:20
@AskAlexSharov
AskAlexSharov added this pull request to the merge queue Jul 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 29, 2026
mriccobene and others added 2 commits July 30, 2026 10:19
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@mriccobene
mriccobene enabled auto-merge July 30, 2026 08:21
@mriccobene
mriccobene added this pull request to the merge queue Jul 30, 2026
Merged via the queue into main with commit e32436c Jul 30, 2026
106 checks passed
@mriccobene
mriccobene deleted the qa-tests/add-claude-skill-for-qa-test-result-analysis branch July 30, 2026 10:11
@taratorio

Copy link
Copy Markdown
Member

for future, can also add a symlink reference for codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants