cmd/downloader: log under [Downloader] in the standalone binary too - #22852
Merged
Conversation
downloadercfg sets LogPrefix to "[Downloader] ", and Downloader.log prepends it to all 29 call sites in db/downloader. The standalone binary overwrites it with "[snapshots] ", so the same code logs under a different component name depending on which binary is running - a grep for either prefix silently misses half the fleet. "[snapshots]" is also already taken: 74 call sites use it for unrelated subsystems (aggregator file building, block retirement, the merger), so the override folds two different components under one name. ## Changes - Drops the LogPrefix override so both binaries emit [Downloader]. - The standalone binary's own two startup lines move to [Downloader] as well.
awskii
enabled auto-merge
July 29, 2026 08:25
AskAlexSharov
approved these changes
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downloadercfgsetsLogPrefixto"[Downloader] ", andDownloader.logprepends it to all 29 call sites indb/downloader. The standalone binary overwrites it with"[snapshots] "atcmd/downloader/main.go:316, so the same code logs under a different component name depending on which binary is running — a grep for either prefix silently misses half the fleet.[snapshots]is also already taken: 74 call sites use it for unrelated subsystems (aggregator file building, block retirement, the merger), so the override folds two different components under one name.Changes
LogPrefixoverride so both binaries emit[Downloader].[Downloader]as well.