Skip to content

[r3.6] go.mod: bump klauspost/compress, otel, quic-go to sync security deps with main - #22865

Merged
lystopad merged 1 commit into
release/3.6from
feature/lystopad/sync-security-deps-3.6
Jul 29, 2026
Merged

[r3.6] go.mod: bump klauspost/compress, otel, quic-go to sync security deps with main#22865
lystopad merged 1 commit into
release/3.6from
feature/lystopad/sync-security-deps-3.6

Conversation

@lystopad

Copy link
Copy Markdown
Member

What

Bumps three security-relevant dependencies on release/3.6 to bring them in line with main:

Module Before After Reason
github.com/klauspost/compress v1.18.6 v1.19.1 GO-2026-5841 — s2 decoder out-of-bounds read (fixed v1.18.7)
go.opentelemetry.io/otel (+/metric, /trace) v1.43.0 v1.44.0 GO-2026-5158 — baggage parsing not length-capped, DoS (fixed v1.44.0)
github.com/quic-go/quic-go v0.59.1 v0.60.0 Sync with main (FIPS 140-3 / bug fixes / Go 1.25 compat; no CVE)

Closes #22863.

Why

release/3.6 was branched from main and drifted. A govulncheck audit found these versions lagging main and/or carrying advisories. Both klauspost/compress and otel findings are classified by govulncheck as not on a proven call path from Erigon code, so real-world severity is low; the bumps keep release/3.6 clean and consistent with main.

Not included

  • crypto/tls (GO-2026-5856) and os (GO-2026-4970) are toolchain-driven, resolved by building with go1.26.5+ — not a dependency version, out of scope here.
  • golang.org/x/crypto/openpgp (GO-2026-5932) has no fix available and the package is unused by Erigon.
  • The x/text, x/net, x/crypto, and go-chi/chi fixes were already present on release/3.6.

Verification

  • go build ./... — clean (no API breakage from any bump)
  • make erigon integration — both binaries build
  • go vet on consumer packages — clean
  • make lint — 0 issues
  • go test -short on all 7 packages consuming the bumped libs — pass
  • govulncheck ./... — GO-2026-5841 and GO-2026-5158 no longer reported

r3.6-specific adaptations

None — straight dependency bump, no code changes required.

Sync security-relevant dependencies on release/3.6 with main.

- klauspost/compress v1.18.6 -> v1.19.1 (GO-2026-5841: s2 decoder OOB read)
- go.opentelemetry.io/otel v1.43.0 -> v1.44.0 (GO-2026-5158: baggage DoS)
- quic-go v0.59.1 -> v0.60.0 (sync with main)
@lystopad lystopad self-assigned this Jul 29, 2026
@lystopad
lystopad enabled auto-merge July 29, 2026 13:20
@yperbasis
yperbasis requested a review from Copilot July 29, 2026 13:37
@yperbasis yperbasis added the dependencies Pull requests that update a dependency file label Jul 29, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates release/3.6 dependency versions for three security-relevant modules to match main, addressing reported govulncheck advisories and reducing version drift on the release branch.

Changes:

  • Bump github.com/klauspost/compress from v1.18.6 to v1.19.1.
  • Bump go.opentelemetry.io/otel (+ otel/metric, otel/trace) from v1.43.0 to v1.44.0.
  • Bump github.com/quic-go/quic-go from v0.59.1 to v0.60.0 (and record new transitive sums).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
go.mod Updates the required versions of compress, otel (and submodules), and quic-go.
go.sum Updates module checksums to match the bumped dependency versions (including new transitive entries).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lystopad lystopad added this to the 3.6.0 milestone Jul 29, 2026
@lystopad
lystopad added this pull request to the merge queue Jul 29, 2026
Merged via the queue into release/3.6 with commit 18fc5f4 Jul 29, 2026
96 checks passed
@lystopad
lystopad deleted the feature/lystopad/sync-security-deps-3.6 branch July 29, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants