Conversation
- Consolidation requires both source and target validators to be active per the Electra spec. - The Pull funds button previously only checked credential type and source-set size, allowing requests against a registered-but-not-yet-active target (e.g. a 1 ETH validator awaiting funds), which the EL silently ignores. - Adds an isValidatorActive helper, uses it in PullConsolidation's disabled predicate, surfaces an explanation in ValidatorActions, and refactors PushConsolidation to share the same helper. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
✅ Deploy Preview for dapper-rolypoly-9814ad ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for phenomenal-frangipane-7c4bd1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Absorb another validator -> Pull funds" action allowed users to initiate a consolidation request targeting a registered-but-not-yet-active validator (e.g. a 1 ETH validator still awaiting funds). Per the Electra consensus spec, consolidations require both source and target validators to be active, so the EL silently ignores these requests, leaving them appearing stuck indefinitely.
Changes
isValidatorActivehelper insrc/utils/validators.tsto centralize the active-status check.PullConsolidation: extended the Pull funds button'sdisabledpredicate to also checkisValidatorActive(targetValidator).ValidatorActions: added an explanatory note under "Absorb another validator" when the validator isn't active, matching the existing pattern for other disabled states.PushConsolidation: refactored the existing inline status check to use the shared helper. No behavior change.Test plan
active_online/active_offline, the Pull funds button remains enabled.pending/pending_initialized/deposited, the Pull funds button is disabled and the explainer appears.exited/slashed, the Pull funds button is disabled.