Repository navigation
Conversation
payno
changed the title
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
payno
force-pushed
the
rename_task_cancel_to_abort
branch
from
October 7, 2026 07:39
eb9af88 to
346fb4a
Compare
payno
commented
Oct 7, 2026
| requires-python = ">=3.8" | ||
| dependencies = [ | ||
| "ewokscore >=5", | ||
| "ewokscore >=5.1.0rc5", |
Member
Author
There was a problem hiding this comment.
We could keep version 5 compatibility but this is a bit cumbersome for the inheritance. So I moved forward. Let me know if there is reason to keep compatibly with version 5.0
payno
force-pushed
the
rename_task_cancel_to_abort
branch
from
October 7, 2026 09:54
346fb4a to
98e02e9
Compare
…ore>=5.1.0rc5) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> # Conflicts: # pyproject.toml
… (ewokscore#514) Task.abort was finally renamed to Task.request_stop, which sets the `stop_requested` flag and calls the `_on_stop_requested` hook that tasks should implement. `stop_requested` is now unambiguously the request (no setter), so the "request vs state" interpretations of `cancelled` are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
payno
force-pushed
the
rename_task_cancel_to_abort
branch
from
October 13, 2026 11:54
b8f12e8 to
628e0ec
Compare
payno
commented
Oct 13, 2026
Comment on lines
-108
to
+109
| class StateCancelTask( | ||
| class InterruptCancelTask( |
Member
Author
There was a problem hiding this comment.
Renamed for clarity. I haven't saw any project using it but still breaking the public API.
Comment on lines
-121
to
+127
| step = 0.05 | ||
| elapsed = 0.0 | ||
| while elapsed < self.inputs.duration: | ||
| if self.__cancel_requested: | ||
| self.cancelled = True | ||
| return | ||
| time.sleep(step) | ||
| elapsed += step | ||
| self.outputs.result = f"slept {elapsed:.2f}s" | ||
| if self.__stop_event.wait(timeout=self.inputs.duration): | ||
| return | ||
| self.outputs.result = f"slept {self.inputs.duration:.2f}s" | ||
|
|
||
| def cancel(self): | ||
| """Interpretation #1: self.cancelled is the state not the request.""" | ||
| self.__cancel_requested = True | ||
| def _on_stop_requested(self): | ||
| self.__stop_event.set() |
Member
Author
There was a problem hiding this comment.
Simplification of the cancellation.
The origin of the modification is that stop_requested (replacing cancelled) has no more setter. It is set directly when stop_requested is called. Which makes it more robust and clarify the states.
This is more 'strict' this way for the best.
payno
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Adapt code to use
Taskabortfunction instead ofcancel.Note
Related to ewoks-kit/ewokscore#514
AI Disclosure