Skip to content

Updating pydata-sphinx-theme to 0.22 - #1002

Merged
bsipocz merged 5 commits into
executablebooks:mainfrom
bsipocz:MAINT_pst_021
Sep 28, 2026
Merged

bsipocz merged 5 commits into
executablebooks:mainfrom
bsipocz:MAINT_pst_021

Conversation

@bsipocz

@bsipocz bsipocz commented Sep 25, 2026

Copy link
Copy Markdown
Member

cc @flying-sheep if you could have a quick look over if you see anything being off with this in the rendering.

@bsipocz bsipocz added the dependencies Pull requests that update a dependency file label Sep 25, 2026
@flying-sheep

flying-sheep commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Looks pretty identical at first glance! The changes seem to be only the type="button" added to the buttons, breaking the tests and making RTD’s “Files changed” list useless:

image

@bsipocz

bsipocz commented Sep 25, 2026

Copy link
Copy Markdown
Member Author

Yeap, I noticed the "button", that will make me regenerate the test files :(

@flying-sheep

flying-sheep commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

no problem! here: bsipocz#1

@jangenoe

Copy link
Copy Markdown

After Updating pydata-sphinx-theme to 0.22, can this theme still be used with jupyterbook 1.0.4, which pins sphinx down to ~7.0?

@bsipocz

bsipocz commented Sep 28, 2026

Copy link
Copy Markdown
Member Author

After Updating pydata-sphinx-theme to 0.22, can this theme still be used with jupyterbook 1.0.4, which pins sphinx down to ~7.0?

No, but you already not able to use the latest releases here as we require sphinx 8+ since we bumped the dependency to 0.19 over the summer. Arguably the changelog is somewhat spotty and I'm sorry for that, some of the automation didn't pick up everything correctly.

@Yann-P

Yann-P commented Sep 28, 2026

Copy link
Copy Markdown

The changes seem to be only the type="button" added to the buttons, breaking the tests and making RTD’s “Files changed” list useless:

yikes, this is due to a linter upgrade upsteram...

can you elaborate on what is broken about "making RTD’s “Files changed” list useless"?

@bsipocz
bsipocz merged commit a57d2af into executablebooks:main Sep 28, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants