[flying-sheep]

fixes #986

[flying-sheep]

Hi, could I get some eyes on this please? Doesn’t seem like the CI failure is mine, and this is a pretty big visual bug in my opinion

[flying-sheep]

@choldgraf @agoose77 @bsipocz all our docs look have been looking bad because of this issue for a month.

Could we please get a release of this within a few days?

[bsipocz]

all our docs look have been looking bad because of this issue for a month.

I'll try to go through the open PRs and merge what I can. That being said, this package is in the same "maintenance" mode as most of the rest of the repositories in this org so downstream users may want to consider pinning versions for their docs deployments, so bugs/mistakes like this would not cause much havoc.

[bsipocz]

Thank you, this looks good at the level of rendering looks fixed and the diff looks reasonable.

[bsipocz]

As I see there have been changes upstream in the newer theme release that is navbar related, I would say I'll try to pull in that update before dealing with any of the other outstanding PRs.

[flying-sheep]

Thank you!

This PR is about adapting to the new pydata-sphinx-theme version and making sure that sphinx-book-theme is compatible with it.

So what do you mean with “pulling in that update”? Isn’t that what this PR did?

[bsipocz]

For historical reasons (I think at least as I don't pin in my other packages) we do have a pinned version up the upstream theme in the dependencies. It's currently pinned to 0.20.0 all the while there is a new 0.21.0 release. So my comment was about bumping this version first and then revisit the other open PRs to spot if those PRs are still relevant and if there is nothing else pops up like this.

[flying-sheep]

Huh, then while my fix works (as you can see your latest docs now look normal again, with no added useless top bar), the cause wasn’t the pydata-sphinx-theme 0.21 release as I assumed!

I wonder what it was then

[bsipocz]

pydata-sphinx-theme 0.21

It must be 0.20, my point is that 0.21 may broke (or maybe fixes) stuff again.

[flying-sheep]

I tested locally, it looks good! Also there’s a test now so the wrong version can’t happen again.

[Yann-P]

too late, but working on a fix upstream (pydata/pydata-sphinx-theme#2507). you will also be able to remove

button.sidebar-toggle {
  display: none;
}

in _header-primary.scss.

[bsipocz]

Thanks @Yann-P for the heads up, I suppose we'll just need to remember to do it once the upstream release is out :)

[Yann-P]

@bsipocz opened here :) #1006

if you have any other frustrations with PST that forces this repo to use some workaround please report upstream