fix: Handle octals inside strings being parsed as integers - #2
Closed
Traxmaxx wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a "bug" in the script where it reads a number represented as a string and converts it to a number instead. Turns out this is a feature!
Strings which look like octal for example
0119are being converted toint. YAML does this to make sure it can do proper duplicate checks:YAML 1.2 will also not accept such strings anymore as the ruyaml maintainer explains:
I'm not convinced that changing the behaviour and handling it manually like introduced in this PR is the right approach. IMHO we should specify strings like "0119" as
!!str "0119"in all schemas instead. Not sure how well that will work with YAML 1.2 though 🤔What is your opinion @fabfuel?