Replace pyyaml with ruyaml to support YAML 1.2 which fixes handling of stringified octal values - #3
Closed
Traxmaxx wants to merge 3 commits into
Closed
Replace pyyaml with ruyaml to support YAML 1.2 which fixes handling of stringified octal values#3Traxmaxx wants to merge 3 commits into
Traxmaxx wants to merge 3 commits into
Conversation
Owner
|
Closing this in favor of #4 - due to to many changes in the compiled OpenAPI file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It works as intended and I added test-data to catch the octal/string behaviour.
I compiled packaging with it and it looks promising. A lot of changes in the compiled file but it does not bother any of our tooling. I'll send you a screenshot in Slack!
I also changed
'ruyaml>=0.91'to'ruyaml==0.91'to disallow package upgrades