Skip to content

style: unify all action buttons to the canonical grayscale chrome - #326

Open
fabiodalez-dev wants to merge 2 commits into
mainfrom
ui/uniform-buttons
Open

style: unify all action buttons to the canonical grayscale chrome#326
fabiodalez-dev wants to merge 2 commits into
mainfrom
ui/uniform-buttons

Conversation

@fabiodalez-dev

@fabiodalez-dev fabiodalez-dev commented Aug 4, 2026

Copy link
Copy Markdown
Owner

What

Unify every action button across the legacy admin/detail views to the canonical grayscale chrome already used by libri, autori, editori and prestiti.

Legacy views (dashboard, plugins, updates, pending loans, integrity report, bulk-enrich, user/author/publisher lists, book detail, loans list, user detail) still coloured their action buttons with per-view accents — blue, green, indigo, purple, orange, amber, cyan. This drifted from the shared palette and made the UI look "almost right but off".

Mapping

  • primarybg-gray-800 text-white hover:bg-gray-700
  • secondarybg-gray-100 text-gray-900 border border-gray-300 hover:bg-gray-200
  • dangerbg-red-600 text-white hover:bg-red-500

Scope & safety

  • 58 buttons across 12 views, class-only swaps — a perfectly balanced 59 / 59 diff, no markup or logic changed.
  • Only genuine interactive elements were touched: every recoloured line carried a hover: state (buttons and action links).
  • Semantic colours were left intact — status badges, alert boxes, the calendar legend dots, stat cards and icons keep their meaning-bearing colours. Verified by scanning the diff for any recoloured line lacking a hover: (none) and any bg-*-100 text-*-800 badge removal (none).

Verification

  • php -l clean on all 12 files.
  • PHPStan level 5: no errors.
  • Rendered spot-check of the dashboard (the view with the most changes): 0 non-canonical action buttons left in the DOM, calendar legend colours preserved.

Summary by CodeRabbit

  • Stile
    • Uniformata la palette dei pulsanti nelle sezioni amministrative e operative dell’interfaccia.
    • Sostituiti diversi colori specifici con tonalità grigie coerenti per azioni, conferme, approvazioni, aggiornamenti e gestione prestiti.
    • Migliorata la coerenza visiva dei pulsanti di azione collettiva, esportazione ed eliminazione.
    • Aggiornati anche gli stati hover e i colori dei controlli relativi a libri, utenti, plugin e manutenzione.

Legacy views still used per-view accent colors (blue/green/indigo/purple/
orange/amber/cyan) for their action buttons, drifting from the canonical
palette used across libri/autori/editori/prestiti. Recolour every genuine
action button to the shared chrome:

- primary  -> bg-gray-800 text-white hover:bg-gray-700
- secondary -> bg-gray-100 text-gray-900 border border-gray-300 hover:bg-gray-200
- danger   -> bg-red-600 text-white hover:bg-red-500

Only interactive elements (buttons and action links, all carrying a hover
state) are touched. Semantic colours are left intact: status badges,
alert boxes, calendar legend dots, stat cards and icons keep their meaning-
bearing colours. 58 buttons across 12 views, class-only swaps (59/59 diff),
no markup or logic changes.
@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@fabiodalez-dev, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 349cb54a-42d0-49fb-9040-873843a2074c

📥 Commits

Reviewing files that changed from the base of the PR and between 786fbc5 and f2ac2a5.

⛔ Files ignored due to path filters (11)
  • composer.lock is excluded by !**/*.lock
  • vendor/composer/autoload_classmap.php is excluded by !vendor/**
  • vendor/composer/autoload_static.php is excluded by !vendor/**
  • vendor/composer/installed.json is excluded by !vendor/**
  • vendor/composer/installed.php is excluded by !vendor/**
  • vendor/guzzlehttp/guzzle/src/Client.php is excluded by !vendor/**
  • vendor/guzzlehttp/guzzle/src/Cookie/SetCookie.php is excluded by !vendor/**
  • vendor/guzzlehttp/guzzle/src/Handler/CurlHandler.php is excluded by !vendor/**
  • vendor/guzzlehttp/guzzle/src/Handler/CurlMultiHandler.php is excluded by !vendor/**
  • vendor/guzzlehttp/guzzle/src/Handler/HostValidator.php is excluded by !vendor/**
  • vendor/guzzlehttp/guzzle/src/Handler/StreamHandler.php is excluded by !vendor/**
📒 Files selected for processing (6)
  • app/Views/admin/plugins.php
  • app/Views/admin/updates.php
  • app/Views/autori/index.php
  • app/Views/dashboard/index.php
  • app/Views/editori/index.php
  • app/Views/libri/scheda_libro.php
📝 Walkthrough

Walkthrough

La modifica uniforma i colori dei pulsanti nelle viste amministrative, dashboard, catalogo, prestiti e utenti. Le azioni, gli identificatori, i dati e i flussi JavaScript restano invariati.

Changes

Palette delle viste

Layer / File(s) Summary
Azioni amministrative operative
app/Views/admin/bulk-enrich.php, app/Views/admin/integrity_report.php, app/Views/admin/pending_loans.php
I pulsanti di arricchimento, manutenzione e gestione prestiti usano palette grigie uniformi.
Configurazione e aggiornamenti amministrativi
app/Views/admin/plugins.php, app/Views/admin/updates.php
I controlli di configurazione, attivazione, salvataggio, installazione e aggiornamento adottano palette grigie o rosse uniformi.
Azioni nelle viste applicative
app/Views/dashboard/index.php, app/Views/autori/index.php, app/Views/editori/index.php, app/Views/libri/scheda_libro.php, app/Views/prestiti/index.php, app/Views/utenti/dettagli_utente.php, app/Views/utenti/index.php
Le azioni dashboard, collettive, bibliografiche, prestiti e utenti aggiornano sfondi, testi e stati hover.

Estimated code review effort: 1 (Trivial) | ~5 minuti

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Il titolo descrive in modo chiaro e conciso l’uniformazione dello stile dei pulsanti alle tonalità di grigio canoniche.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ui/uniform-buttons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant