Repository navigation
feat(suite): add support for constraining execution by architecture - #322
Merged
Merged
Conversation
The user can specify a `runIf` field to require that the test is
eligible for execution only under specific settings. The only
constraint that can currently be applied is an architecture-based one.
Currently, only two architecture are supported: "amd64" and "arm64".
The `suite render` sub-command gained a new `--eligible` flag that
changes the semantic of the tool: if provided, only eligible tests are
taken into account. Notice that using `--eligible` together with
`--count` results in the output of the eligible tests count: this
number is what the new version of the GitHub action returns as
`expected-tests`.
Specifying an eligibility condition looks like the following:
```YAML
tests:
...
runIf: arch: {op: "eq", val: "amd64"}
...
```
Moreover, fix a small (but harmless) bug in `decodeTestStepType()`.
Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
leogr
approved these changes
Jul 23, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekoops, leogr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
/kind feature
Any specific area of the project related to this PR?
/area commands
/area pkg
/area automation
What this PR does / why we need it:
This PR adds support for constraining tests execution by architecture. The user can specify a
runIffield to require that the test is eligible for execution only under specific settings. As previously stated, the only constraint that can currently be applied is an architecture-based one. Currently, only two architecture are supported: "amd64" and "arm64". Thesuite rendersub-command gained a new--eligibleflag that changes the semantic of the tool: if provided, only eligible tests are taken into account. Notice that using--eligibletogether with--countresults in the output of the eligible tests count: this number is what the new version of the GitHub action returns asexpected-tests.Specifying an eligibility condition looks like the following:
Moreover, this PR fixes a small (but harmless) bug in
decodeTestStepType().Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: