feat(ml): deprecate Machine Learning APIs - #981
Open
yvonnep165 wants to merge 3 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request deprecates the Firebase ML module, adding deprecation warnings and updating docstrings across its functions and classes, along with corresponding unit tests. The review feedback recommends introducing a helper function to inspect the call stack and guard the deprecation warnings, which prevents duplicate warning flooding when public APIs internally invoke other deprecated methods or instantiate deprecated classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR deprecates the Firebase Machine Learning module, functions, and classes ahead of the service turndown on June 15, 2027. Developers are instructed to migrate their custom model hosting workflows directly to Cloud Storage for Firebase. Unit tests are added to verify that
DeprecationWarningis triggered with the expected message.