Repository navigation
Cancel overlapping docs runs for the same PR - #46
Open
fivetran-data-model-bot wants to merge 2 commits into
Open
fivetran-data-model-bot wants to merge 2 commits into
fivetran-data-model-bot wants to merge 2 commits into
Conversation
Applying docs:ready twice started two generate runs in parallel. The second lost the push race (rejected, fetch first), and its failure step removed the label even though the first run had already pushed current docs and CHANGELOG.md. A per-PR concurrency group makes the later run wait and start from the updated branch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Only the most recent docs:ready run matters, like Buildkite. A cancelled run doesn't trigger the failure() steps, so the label isn't removed, and the new run starts after the cancelled one stops. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 task
2 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs:readytwice in a row starts twogenerate-docs.ymlruns in parallel. Both check out the same commit, so the second one's push gets rejected (fetch first). Its failure step then removesdocs:readyand posts a failure status, even though the first run already pushed current docs andCHANGELOG.md.concurrencygroup per repo + PR, withcancel-in-progress: true. Only the latest run matters, like Buildkite: a new run cancels the one in progress.if: failure()steps, so the label stays and no failure status is posted.Real-world repro
dbt_salesforce#93 at 20:51 on 10/30:
docs:readywas applied twice (20:51:02 and 20:51:16), starting two generate runs on212414d.b4751ccat 20:52:23, and the check then posted success.Not covered here
check-docs-current.ymlcan still remove the label when it finishes after you've already applied it. That happens when the check from your own push reports stale (correctly) right after you adddocs:ready. That's a separate behavior question: whether the check should remove the label at all, or rely only on the status.Test plan
docs:ready, remove it, and re-apply it quickly. The first run should show as cancelled, the second should succeed, and the label should stay.🤖 Generated with Claude Code