Repository navigation
Allow additional parameters for the authorization request - #41
Merged
Merged
Conversation
startAuthorization() and startAuthorizationWithId() now accept additional query parameters for the authorization endpoint, for example "prompt", "login_hint" or "ui_locales". Parameters which the client sets itself, like "state" or "redirect_uri", are rejected. Previously, callers could only pass the scope. Other parameters had to be appended to the returned URI afterwards.
The test matrix no longer cancels the remaining jobs after the first failure. This shows at a glance which combinations of PHP versions and dependency sets are affected.
The package now requires league/oauth2-client 2.9 or later. Version 2.9.0 is the first release which supports PHP 8.5. Older releases declare parameters as implicitly nullable, which PHP 8.4 and later report as deprecated. With the lowest dependencies, a test which creates an authorization URI therefore failed on PHP 8.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startAuthorization()andstartAuthorizationWithId()now accept additional query parameters for the authorization endpoint, for exampleprompt,login_hintorui_locales. Parameters which the client sets itself, likestate,scopeorredirect_uri, are rejected with an exception.Until now, callers could only pass the scope and had to append other parameters to the returned URI afterwards.