Skip to content

Isolate controller test storage - #2139

Open
kVinsom wants to merge 2 commits into
fluxcd:mainfrom
kVinsom:codex/issue-1099-isolate-test-storage
Open

Isolate controller test storage#2139
kVinsom wants to merge 2 commits into
fluxcd:mainfrom
kVinsom:codex/issue-1099-isolate-test-storage

Conversation

@kVinsom

@kVinsom kVinsom commented Aug 24, 2026

Copy link
Copy Markdown

Summary

  • give direct reconciler tests isolated storage directories and URL prefixes
  • reuse the suite artifact server instead of starting one server per test
  • keep manager-owned reconcilers on a dedicated managerStorage
  • seed only the required Helm cache artifact instead of copying the complete fixture tree
  • cover storage URL isolation, parallel access, and cleanup

Testing

  • go vet ./internal/controller
  • affected Bucket, GitRepository, HelmChart, HelmRepository, and OCIRepository tests
  • go test ./internal/controller -run '^TestNewTestStorageForTest$' -count=20

Closes #1099

Create a dedicated artifact server and storage directory for each reconciler test. Keep manager-owned reconcilers on their own storage and copy Helm fixtures into isolated cache tests.

Fixes fluxcd#1099

Signed-off-by: Mykola <kachmarykmi@gmail.com>
Assisted-by: Codex/GPT-5
Reuse the suite artifact server with per-test URL prefixes to avoid spawning an HTTP server for every test. Seed only required Helm cache artifacts and add parallel, HTTP isolation, and cleanup coverage.

Signed-off-by: Mykola <kachmarykmi@gmail.com>
Assisted-by: Codex/GPT-5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Isolate storage used in tests

1 participant