Repository navigation
Update Stage 1 templates and solutions (through 1B) sim classes for 1C - #370
Open
roboteer5291 wants to merge 6 commits into
Open
roboteer5291 wants to merge 6 commits into
roboteer5291 wants to merge 6 commits into
Conversation
|
🌐 Preview URL: https://pr-370.frcsoftware.org Changed pages |
roboteer5291
marked this pull request as ready for review
October 6, 2026 20:12
DylanB5402
approved these changes
Oct 8, 2026
DylanB5402
left a comment
Member
There was a problem hiding this comment.
Looks good, though I'll note that I haven't had the time to actually test this in sim myself. Nothing here looks breaking though, so approving.
Also noting that it's kinda annoying how many times we have the Sim classes duplicated. Wonder if there's any more intelligent way to manage that, out of scope for this PR of course.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stage 1C comes with a few sim class changes (starting the robot with fuel, updated rev drivetrain sim), and this pulls them forward to Stage 1's templates and solutions to reduce the number of users that get to 1C (once completed) with an outdated template.
Meta
Merge checklist: