fix(unity-builder): retry mac builds on Unity's transient licensing-client signature error - #226
Merged
Merged
Conversation
…lient signature error Root cause of the "Cancelled after 65m" and one-off macOS build failures seen on game-ci/unity-builder#844's CI: Unity's own Licensing Client occasionally fails its own codesign verification ("Error: Code 10 while verifying Licensing Client signature") right after a fresh Unity Hub install on a GitHub-hosted runner, before any real build work starts. It's a known, transient Unity/macOS flake, not something this tool can fix in Unity itself - but failing an entire build (and the PR check with it) on a licensing hiccup unrelated to the actual build's correctness is exactly the false-negative CI signal we don't want: it tells us nothing about whether this tool is working. MacBuilder.run now retries up to 3 times with a 10s backoff, but only when the failure output matches this specific known-transient pattern - any other failure (a real compile error, etc.) still fails immediately on the first attempt, so this can't mask genuine build breakage.
|
Warning Review limit reachedNext included review available in 24 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Error: Code 10 while verifying Licensing Client signature) right after a fresh Unity Hub install on a GitHub-hosted runner, before any real build work starts.MacBuilder.runnow retries the whole invocation up to 3 times (10s backoff) only when the output matches this specific known-transient error pattern. Any other failure (a real compile error, etc.) still fails immediately on the first attempt — this can't mask genuine build breakage.Test plan
mac-builder.test.ts: succeeds without retry, fails immediately on unrelated errors, retries+recovers on the transient pattern, gives up after 3 attempts and returns the real exit codevitest run— 458/458 pass (4 new)tsc --noEmit— clean