fix: forward documented Android signing options to Unity

[tarikermis]

Changes

The documented --androidKeystorePassword, --androidKeyAlias and --androidKeyAliasPassword flags are parsed correctly, but the Unity environment builders read different option names. This drops the supplied signing values before they reach the build process.

This forwards the documented options in the container environment and native macOS setup, with deprecated aliases and previously consumed spellings kept as fallbacks. The password names are also registered with the existing log redactor.

Added coverage for parsed flags, compatibility, precedence, password masking and native setup. bun run test passes with 311 tests and 3 skips. Four of the five parser regression tests fail on current main and all pass with this change. The Bun-target bundle and embedded-asset check also pass. No live Unity or Android signing build was run.

Checklist

• Read the contribution guide and accept the code of conduct
• Readme (not needed; this restores the documented flags)
• Tests (added)

Best Regards, Tarik

Summary by CodeRabbit

• Bug Fixes
  • Android signing credentials now correctly populate the required environment settings across Unity setup workflows.
  • Documented option names take precedence when both current and legacy spellings are provided.
  • Existing deprecated and legacy option spellings remain supported for compatibility.
  • Keystore and key-alias passwords are now consistently hidden in output and logs, while alias names remain visible.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 6445d5c8-97bc-4c2c-8738-79c23cf85e76

📥 Commits

Reviewing files that changed from the base of the PR and between 0588a64 and 9139929.

📒 Files selected for processing (6)

• src/command-options/android-options.test.ts
• src/logic/unity/environment.test.ts
• src/logic/unity/environment.ts
• src/logic/unity/platform-setup/setup-mac.test.ts
• src/logic/unity/platform-setup/setup-mac.ts
• src/model/secret-redaction.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

Android signing options now forward documented names to environment variables, retain deprecated and legacy aliases, and redact password values. Unity environment generation and macOS setup use matching precedence rules with regression coverage.

Changes

Android signing credential forwarding

Layer / File(s)	Summary
CLI option forwarding and redaction src/model/secret-redaction.ts, src/command-options/android-options.test.ts	Registers Android signing passwords for redaction. Tests cover canonical, deprecated, and legacy flags.
Unity environment precedence src/logic/unity/environment.ts, src/logic/unity/environment.test.ts	Maps documented Android signing options first, then deprecated and legacy aliases.
macOS setup precedence src/logic/unity/platform-setup/setup-mac.ts, src/logic/unity/platform-setup/setup-mac.test.ts	Applies the same fallback order during local setup and verifies environment restoration.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 91399

Documented Android signing flags now reach Unity in container and native macOS flows while preserving compatible fallback spellings and masking password values. The covered forwarding and precedence behavior is ready to merge.

Suggested reviewers: frostebite

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description check	✅ Passed	The description follows the required template. It explains the change, compatibility behavior, test coverage, validation results, and limitations. All checklist items are addressed.
Title check	✅ Passed	The title clearly and concisely describes the main change: forwarding documented Android signing options to Unity.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 6 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}