Adapt to NeoNephos changes - #1064
Conversation
✅ Deploy Preview for gardener-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
marc1404
left a comment
There was a problem hiding this comment.
Thanks for clarifying these! 🙏
BoHristova
left a comment
There was a problem hiding this comment.
Thank you for updating those, @timuthy!
And your PR has an added bonus. Thanks to it, I noticed that the Pull Request Creation Guidelines doc is misplaced. It should be in the Contribution Process section 😅 So thanks for that, too.
3970f0f to
47c780b
Compare
Signed-off-by: Tim Usner <tim.usner@sap.com>
Signed-off-by: Tim Usner <tim.usner@sap.com>
Signed-off-by: Tim Usner <tim.usner@sap.com>
47c780b to
1d0aa09
Compare
1d0aa09 to
4b1f2c9
Compare
Signed-off-by: Tim Usner <tim.usner@sap.com>
4b1f2c9 to
2dfce94
Compare
|
I've addressed your feedback and moved the documentation, thanks for the hint @BoHristova 🙂 |
There was a problem hiding this comment.
Thank you for going the extra mile and moving the PR guidelines to the correct section, @timuthy 🙏
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BoHristova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 910422e3c3d17b2d560c7eb6f5e7c400f50a4399 |
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Signed-off-byrequirement in PR creation guide.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @marc1404