Conversation
`oklab2rgb` and `oklch2rgb` (like the `gl` input) return no alpha
channel for opaque colors, but `clip_rgb` always clamped index 3, turning
the missing value into `NaN` before the constructor could default it to
1. `chroma.oklch(0.5, 0.1, 20).alpha()` returned `NaN` and
`.hex('rgba')` returned `#944a4baN`; since gka#399, mixing or scaling such
a color throws `invalid rgb color`.
Only clamp alpha when it is present.
🦋 Changeset detectedLatest commit: 64a8897 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Colors built through the
oklab,oklchorglconstructors without an explicit alpha end up with an alpha ofNaN:oklab2rgbandoklch2rgb(like theglinput) return only[r, g, b]for opaque colors.clip_rgbthen always clamped index 3, which turned the missing value intoNaNbefore theColorconstructor could default it to 1. Theif (me._rgb.length === 3) me._rgb.push(1)fallback therefore never ran for these inputs.This PR makes
clip_rgbclamp alpha only when it is present, so the constructor's default applies. The otherclip_rgbcallers (average,cubehelix) always pass four values and are unaffected, and_unclippedis copied before the loop, so it is unchanged.Tests: added two cases to
test/alpha.test.jsfor the alpha default and for mixing/scaling such a color; both fail without the change. Full vitest suite: 2534 passing. A changeset is included.