Bump gfx so SVGIcon draws stroke packs correctly - #433
Merged
Conversation
gfx's SVG rasteriser never read the root <svg>'s own presentation attributes, so a pack that declares fill="none" once on the root had every closed path filled. Iconoir's magnifier came through SVGIcon as a solid disc; the open handle path still stroked, so it looked deliberate. Fixed in go-gfx/gfx#33 and released as v0.18.0. Verified here through the seam consumers actually use — SVGIcon onto a real PixelPainter — not through gfx directly: the magnifier is a stroked loupe again, 8.8% dark coverage in its box where the filled disc was 40%. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
rougelex carries 'replace github.com/go-widgets/toolkit => ../', so it builds against the parent working copy — which means any change to the parent's dependencies leaves its own go.mod stale, and 'go vet' refuses with 'updates to go.mod needed'. Bumping gfx in the parent did exactly that. Caught by CI rather than locally: I had run build, vet and tests on the parent module but not the nested one, and not the coverage gate. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gfx's SVG rasteriser never read the root
<svg>'s own presentation attributes, so a pack that declaresfill="none"once on the root had every closed path filled. Iconoir's magnifier came throughSVGIconas a solid disc — the open handle path still stroked, so it looked deliberate rather than broken.Fixed in go-gfx/gfx#33, released as v0.18.0.
Verified here through the seam consumers actually use —
SVGIcononto a realPixelPainter, not gfx directly: the magnifier is a stroked loupe again, 8.8% dark coverage in its box where the filled disc was 40%.This unblocks the icon ports held as drafts in go-reddit/reader, go-xrkit/player and go-pkgx/registry-viewer.
Only
go.mod/go.sumchange. gofmt clean, build, vet, tests pass.🤖 Generated with Claude Code