feat(dialog): collapse the action strip when there are no Buttons - #434
Merged
Conversation
The Dialog always reserved a 32px bottom action strip, so a modal that wants to keep its controls inside Content (a card with inline buttons, like a hand-built panel) got an empty SurfaceAlt strip under its body. Make the strip height zero when Buttons is empty: Content then fills the whole body and no strip is drawn. Dialogs with action buttons are unchanged. This lets the Dialog be the single high-level modal frame for both button-strip and inline-button layouts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Dialogalways reserved a 32px bottom action strip, so a modal that keeps its controls insideContent(a card with inline buttons) got an emptySurfaceAltstrip under its body. Make the strip height zero whenButtonsis empty:Contentfills the whole body and no strip is drawn. Dialogs with action buttons are unchanged — this lets theDialogbe the single high-level modal frame for both button-strip and inline-button layouts. Pixel-tested; 100% coverage gate green.